Remove obsolete operators.hh utility #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The utility classes in `operators.hh` overlap with `broker::detail::comparable`. There is no need to have both in the code base, so we remove the `operators.hh` header and instead use `comparable` consistently.
ckreibich
force-pushed
the
topic/neverlord/obsolete-operators-header
branch
from
3f4d023
to
475e0b9
Compare
ckreibich
added a commit
to zeek/zeek
that referenced
this pull request
Oct 23, 2024
This pulls in zeek/broker#424, zeek/broker#430, zeek/broker#431.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The utility classes in
operators.hhoverlap withbroker::detail::comparable. There is no need to have both in the code base, so we remove theoperators.hhheader and instead usecomparableconsistently.