Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PATHS vs HINTS carefully in FindZeek.cmake's find_package() #120

Open
ckreibich opened this issue Oct 31, 2024 · 0 comments
Open

Use PATHS vs HINTS carefully in FindZeek.cmake's find_package() #120

ckreibich opened this issue Oct 31, 2024 · 0 comments

Comments

@ckreibich
Copy link
Member

Per a Slack conversation it looks like the way we use HINTS in find_package(), including fixed path guesses like /usr/local/zeek/bin, can have the undesired effect of overriding system-level defaults for locating a program — here, picking up zeek-config straight from the user's PATH environment.

The docs suggest that we should use HINTS for paths derived from other variables (here, relative to ${ZEEK_ROOT_DIR}), while we should provide absolute paths via PATHS, which will come last in the resolution order.

There are several other uses of HINTS in our cmake tree that we should review while we're at it.

cmake gurus, feel free to chime in...

@ckreibich ckreibich changed the title Use PATHS, not HINTS, in FindZeek.cmake's find_package() Use PATHS vs HINTS carefully in FindZeek.cmake's find_package() Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant