You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Per a Slack conversation it looks like the way we use HINTS in find_package(), including fixed path guesses like /usr/local/zeek/bin, can have the undesired effect of overriding system-level defaults for locating a program — here, picking up zeek-config straight from the user's PATH environment.
The docs suggest that we should use HINTS for paths derived from other variables (here, relative to ${ZEEK_ROOT_DIR}), while we should provide absolute paths via PATHS, which will come last in the resolution order.
There are several other uses of HINTS in our cmake tree that we should review while we're at it.
cmake gurus, feel free to chime in...
The text was updated successfully, but these errors were encountered:
ckreibich
changed the title
Use PATHS, not HINTS, in FindZeek.cmake's find_package()
Use PATHS vs HINTS carefully in FindZeek.cmake's find_package()Oct 31, 2024
Per a Slack conversation it looks like the way we use
HINTS
infind_package()
, including fixed path guesses like/usr/local/zeek/bin
, can have the undesired effect of overriding system-level defaults for locating a program — here, picking upzeek-config
straight from the user'sPATH
environment.The docs suggest that we should use
HINTS
for paths derived from other variables (here, relative to${ZEEK_ROOT_DIR}
), while we should provide absolute paths viaPATHS
, which will come last in the resolution order.There are several other uses of
HINTS
in our cmake tree that we should review while we're at it.cmake gurus, feel free to chime in...
The text was updated successfully, but these errors were encountered: