Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine auto-open Picture-in-Picture (PiP) Behavior to Exclude Background Video Elements #3145

Open
3 of 4 tasks
phrechu opened this issue Nov 21, 2024 · 0 comments
Open
3 of 4 tasks

Comments

@phrechu
Copy link

phrechu commented Nov 21, 2024

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

Description

The current auto-open PiP implementation incorrectly triggers for video elements used as backgrounds or embedded in div sections, rather than focusing on actual video players.

Expected Behavior

Maintain auto-open PiP functionality for genuine video players (YouTube, Vimeo, etc.)
Prevent PiP activation for:

  • Background videos
  • Decorative video elements
  • Non-primary video content in website sections

Proposed Solution

Implement logic to distinguish between:

  • Primary video players intended for content consumption
  • Decorative or background video elements

Technical Suggestion

Consider using heuristics like:

  • Video size
  • Presence of player controls
  • Context of video element in the page structure

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.19

What platform are you seeing the problem on?

Windows

Relevant log output

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triage
Development

No branches or pull requests

1 participant