-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Bluetooth: ISO: BIS: Add fragmented data test #82038
Draft
cvinayak
wants to merge
12
commits into
zephyrproject-rtos:main
Choose a base branch
from
cvinayak:iso_fragment_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+427
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redundant only used as a sanity check, |
cvinayak
force-pushed
the
iso_fragment_test
branch
2 times, most recently
from
November 26, 2024 13:47
d3b8065
to
615a3c6
Compare
Fix ISO Sync Receiver implementation to correctly reflect the payload number and timestamp for the skipped SDU. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix ISO Sync Receiver time reservation calculation to use peer broadcasted bis_spacing and sub_interval, instead of incorrectly calculating using local implementation used tMSS value. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix ISO Sync Receiver implementation to correctly prevent subevent from pre-empted in the unreserve time space. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Align audio test Controller Kconfig value same as used with nRF53bsim. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Enable some high reliability CAP tests by increasing ISO Tx buffer counts in the Controller to sufficiently generate number of complete when multiple SDUs are transmitted in single ISO interval with use of pre-transmissions. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Enable support for building and running the BIS ISO host test on the nRF5340bsim board. The purpose of this is to test the ISO fragmentation on both the nRF52bsim and nRF5340bsim, as they use different drivers. Signed-off-by: Emil Gydesen <[email protected]>
Fix ISO Tx PDU buffer count required when SDUs fragmentation is used. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Remove unused BT_CTLR_CONN_ISO_SDU_LEN_MAX, required Tx PDU buffer counts are now calculated using ISO Tx Buffer size. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Since the SDUs are now allocated by the application and the host does not care about the SDU sizes, the check is useless. Signed-off-by: Emil Gydesen <[email protected]>
Modify the test to use the controller buffer size as the maximum SDU size, so per default we can send up to the maximum size the controller supports. This ensures that the tests will never do fragmentation over HCI. This also adds verification of the received data on the ISO sync receiver. Signed-off-by: Emil Gydesen <[email protected]>
Add a test for broadcast ISO that uses fragmentation. The host will attempt to send SDUs 3 times the HCI ISO data buffer size, so that it will be fragmented into a BT_ISO_START, BT_ISO_CONT and a BT_ISO_END HCI ISO data packet. Signed-off-by: Emil Gydesen <[email protected]>
…size Modify the test to use the controller buffer size as the maximum SDU size, so per default we can send up to the maximum size the controller supports. This ensures that the tests will never do fragmentation over HCI. This also adds verification of the received data on the ISO sync receiver. Signed-off-by: Emil Gydesen <[email protected]>
cvinayak
force-pushed
the
iso_fragment_test
branch
from
November 27, 2024 04:49
615a3c6
to
c7b1269
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for broadcast ISO that uses fragmentation.
The host will attempt to send SDUs 3 times the HCI ISO
data buffer size, so that it will be fragmented into a
BT_ISO_START, BT_ISO_CONT and a BT_ISO_END HCI ISO data
packet.
Signed-off-by: Emil Gydesen [email protected]