scripts: process_gperf: upgrade the asso_values type to unsigned short #82090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
57300,
ceolin,
dcpleung,
jeremybettis,
nashif,
nordicjm and
tejlmand
cfriedt
added
the
Hotfix
cfriedt
previously approved these changes
Nov 27, 2024
|
@ycsin - can you verify that this fixes the issue? I'm heading off to sleep |
|
@tagunil - can you possibly rebase and readjust testcase.yml for the suite that was failing? |
The gperf tool automatically selects the optimal data type for the asso_values table, depending on MAX_HASH_VALUE. However, there is a corner case when the tables generated on different stages of the build process have different data types, causing a link-time error. Upgrade the data type for the table from unsigned char to unsigned short to at least exclude this 8-bit to 16-bit transition. There is another potential issue with the 16-bit to 32-bit transition, but it seems not very likely to have 65k kernel objects anytime soon. Signed-off-by: Ilya Tagunov <[email protected]>
tagunil
force-pushed
the
upgrade_gperf_table
branch
from
8c6278a
to
25fac80
Compare
…_em" This reverts commit f415724. This is fine, as the underlying issue is solved. Signed-off-by: Ilya Tagunov <[email protected]>
tagunil
force-pushed
the
upgrade_gperf_table
branch
from
25fac80
to
d3a2657
Compare
tejlmand
approved these changes
Nov 27, 2024
cfriedt
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gperf tool automatically selects the optimal data type for the asso_value table, depending on the MAX_HASH_VALUE. However, there is a corner case when the tables generated on different stages of the build process have different data types, causing a link-time error. Upgrade the data type for the table from unsigned char to unsigned short to at least exclude this 8-bit to 16-bit transition. There is another potential issue with the 16-bit to 32-bit transition, but it seems not very likely to have 65k kernel objects anytime soon.
Fixes: #82059