Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zmarkdown: fix Sentry error reporting #499

Closed
StaloneLab opened this issue Nov 18, 2023 · 0 comments · Fixed by #511
Closed

zmarkdown: fix Sentry error reporting #499

StaloneLab opened this issue Nov 18, 2023 · 0 comments · Fixed by #511
Assignees
Labels
semver/bugfix This is a minor backward-compatible fix status/verified This has been checked by a maintainer type/meta This is not directly related to the code

Comments

@StaloneLab
Copy link
Member

Error reporting on Sentry is quite weird by now, it seems to report some things but not others. Currently, I would describe the behavior as almost useless because:

  • we do not get any contextual information, so cannot help users encountering weird bugs;
  • some errors might not be logged. At least, no errors were logged in a long time;
  • the latest error which got thrown should not have been an error IMO, because invalid Markdown (table with two headers) was entered;
  • warning are not logged, which leads to problems such as the one noticed in Passage à zmarkdown 11.3.0 zds-site#6410 (comment) (in French), that cannot be reproduced.

As a result of these problems, we get garbage when an error should in fact be silent and nothing when an error should be reported.
I am unsure of how the problem can be solved, but I will look at it for the upcoming version.

@StaloneLab StaloneLab added semver/bugfix This is a minor backward-compatible fix type/meta This is not directly related to the code status/verified This has been checked by a maintainer labels Nov 18, 2023
@StaloneLab StaloneLab added this to the [email protected] milestone Nov 18, 2023
@StaloneLab StaloneLab self-assigned this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/bugfix This is a minor backward-compatible fix status/verified This has been checked by a maintainer type/meta This is not directly related to the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant