Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mechanism to output all incomplete inbound ballots #3315

Open
CryptoFewka opened this issue Dec 17, 2024 · 1 comment · May be fixed by #2863
Open

Add a mechanism to output all incomplete inbound ballots #3315

CryptoFewka opened this issue Dec 17, 2024 · 1 comment · May be fixed by #2863
Labels
feature:idea An early idea for a feature. Used as reference to follow new feature integrations

Comments

@CryptoFewka
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It is difficult to determine if all observers are observing newly integrated chains. In order to determine the observer voting status for an inbound transaction, we currently would have to collect the inbound ballot identifier from the logs of an observer, and then call /zeta-chain/observer/has_voted/{ballot_identifier}.

Describe the solution you'd like
Ideally there would be a way to list open ballots as well as who has voted. Presumably there already is a mechanism for this inside of the protocol, but it is not exposed currently.

Describe alternatives you've considered
Vote messages could be pulled from the blockchain itself, but would require the use of an indexer and a custom solution.

Motivation and Context
We would like to monitor inbound CCTX observation, and would like an API endpoint to output inbound CCTX observation, or a mechanism to determine the ballot identifier that can then be used with /zeta-chain/observer/has_voted/{ballot_identifier} to monitor voting.

@CryptoFewka CryptoFewka added the feature:idea An early idea for a feature. Used as reference to follow new feature integrations label Dec 17, 2024
@lumtis
Copy link
Member

lumtis commented Dec 18, 2024

FWIW with #2863 merged, the listBallot query would then list all pending ballots (instead of all ballots in the system) because completed ballots will be removed from the store.
We kept it aside because it was not seen as a direct priority and wanted to avoid the extensive upgrade migration of removing all ballots for now but if it is important we can look into have this one for the next release, I believe it would address the issue.

@lumtis lumtis linked a pull request Dec 18, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:idea An early idea for a feature. Used as reference to follow new feature integrations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants