Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Button for JSON input #2

Open
p-shah opened this issue Mar 30, 2017 · 6 comments
Open

Clear Button for JSON input #2

p-shah opened this issue Mar 30, 2017 · 6 comments
Assignees

Comments

@p-shah
Copy link

p-shah commented Mar 30, 2017

Awesome service but there's no button to clear the input.

@zgrossbart
Copy link
Owner

Thank you for the comment. You can press the "Perform a new diff" button, remove the input manually, or refresh the page. What kind of button are you looking for?

@zgrossbart zgrossbart self-assigned this Mar 30, 2017
@p-shah
Copy link
Author

p-shah commented Mar 30, 2017

Just to have the option to not have to manually each time. But if it was designed purposely that way, my bad.

@zgrossbart
Copy link
Owner

No need for a mea culpa. I'm really curious what you mean. Were you looking for a clear button while you were using the page? When did you want it? I want to make this as usable as possible. Thank you for the help.

@p-shah
Copy link
Author

p-shah commented Mar 30, 2017

Yeah I was just using JSON diff service and noticed everytime I tried to perform a new diff I had to manually clear the input on each side. I figured to a button clear above each of the inputs would be useful. Thanks for the service.. Super helpful.

@zgrossbart
Copy link
Owner

That makes sense. I was torn about that feature. Right now I don't clear the inputs when you perform a new diff based on the idea that you might want to change the existing input rather than have something totally new. What do you think? Does it make sense to clear the input there?

I'm also trying to keep everything really simple and not add more buttons that an absolutely have to.

@saurabheights
Copy link

saurabheights commented May 30, 2017

@zgrossbart : My two cents here: Although, I am wary of this functionality as well, however a warning message box regarding "Do you want to really clear all data?" should be sufficient. Clearing the input manually is more effort than the two clicks, one for the clear button and one for the confirm.

One more thought in keeping the ui simple - you can keep all advanced options at the bottom and initially hidden. When user selects the advanced options button, then the panel of all options appears. For naive user's, this should suffice. For intermediate/advanced users, having a right taxonomy of the options in the panel would further simplify the use of this options. Adding an information("i") button to these options would even be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants