Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Make new diff button sticky #21

Open
Hillshum opened this issue Oct 16, 2018 · 8 comments
Open

Enhancement: Make new diff button sticky #21

Hillshum opened this issue Oct 16, 2018 · 8 comments
Assignees

Comments

@Hillshum
Copy link

Currently, the button to start a new diff is only available at the top of the page, requiring scrolling upwards to access it. If I'm halfway down a giant diff, scrolling upwards is rather annoying. There's plenty of room in the sidebar for the button. Can it be put there?

I realize this is a pretty simple change, and I might just do it myself after I get home from work today.

@zgrossbart zgrossbart self-assigned this Oct 16, 2018
@zgrossbart
Copy link
Owner

Thank you very much for the enhancement. There's a bit of a space issue here. I wouldn't want to put the new button the top of the side bar since you want the focus to be on the next and previous buttons. However, I wouldn't want to put it at the bottom because it would jump around when you look at different differences.

Any ideas where we should put the button?

@Hillshum
Copy link
Author

Pin it to the very bottom of the sidebar? That way it won't jump around if the list of differences varies in length, and it doesn't interfere with the nav buttons at the top of the sidebar.

@zgrossbart
Copy link
Owner

What would happen if you had enough diffs and a short enough screen to have an overlap?

@Hillshum
Copy link
Author

Scroll? You could have diffs overflowing even without an additional button, though the button does make it more likely to happen, regardless of where the button is positioned.

@zgrossbart
Copy link
Owner

We can scroll, but then we can't make it have a fixed position and it might still be off the screen.

@Hillshum
Copy link
Author

The button could be fixed to the bottom with the diffs scrolling in a box just above.

@Hillshum
Copy link
Author

Or just put the diff viewer on a different path from the input fields so that the back button works.

@zgrossbart
Copy link
Owner

I'll see if I can find some time to play with it later today. Feel free to do a PR if you have a better idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants