Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple sourcebuffer #49

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Mar 29, 2019

feat: multiple sourcebuffer

Description

use two sourcebuffer to manage audio and video track

see #14

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xiaoyuhen xiaoyuhen added the enhancement✨ New feature or request label Mar 29, 2019
@xiaoyuhen xiaoyuhen requested a review from liuwuhaoo March 29, 2019 08:34
@codecov-io
Copy link

codecov-io commented Mar 29, 2019

Codecov Report

Merging #49 into master will increase coverage by <.01%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   52.98%   52.99%   +<.01%     
==========================================
  Files         123      123              
  Lines        1659     1672      +13     
==========================================
+ Hits          879      886       +7     
- Misses        780      786       +6
Impacted Files Coverage Δ
packages/griffith-mp4/src/fmp4/boxes/moov.js 100% <ø> (ø) ⬆️
packages/griffith-mp4/src/mse/controller.js 0% <0%> (ø) ⬆️
packages/griffith-mp4/src/mp4/utils/findBox.js 100% <100%> (ø) ⬆️
...s/griffith-mp4/src/mp4/utils/getSamplesInterval.js 95.08% <100%> (+0.16%) ⬆️
packages/griffith-mp4/src/fmp4/fmp4Generator.js 100% <100%> (ø) ⬆️
packages/griffith-mp4/src/mp4/boxes/elst.js 93.33% <66.66%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9415b63...c4dd339. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit ac64d8a into zhihu:master Mar 29, 2019
@xiaoyuhen xiaoyuhen mentioned this pull request Apr 2, 2019
@xiaoyuhen xiaoyuhen deleted the sourcebuffer branch April 2, 2019 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants