Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed coveralls issues with KeyError and HTTP 422 Unprocessable Entity #1138

Merged
merged 1 commit into from
Apr 30, 2023
Merged

Fixed coveralls issues with KeyError and HTTP 422 Unprocessable Entity #1138

merged 1 commit into from
Apr 30, 2023

Commits on Apr 30, 2023

  1. Fixed coveralls issues with KeyError and HTTP 422 Unprocessable Entity 

    Details:

* Increased minimum version of coveralls to 3.3.0 since it is the first
  version that allows overriding the service_job_id parameter via an
  environment variable.

* In the test workflow, specified two changes that solved both issues:
  * Changed the service name to 'github' (the default is 'github-actions')
  * Set the service_job_id request parameter by setting the
    COVERALLS_SERVICE_JOB_ID env var to GITHUB_RUN_ID.

* Improved the build ID shown on coveralls.io, to workflow name
  plus run number of that workflow. This allows for easier matching
  of Github Actions runs and coveralls.io builds.

Signed-off-by: Andreas Maier <[email protected]>
    @andy-maier
    andy-maier committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    dc1c0e3 View commit details
    Browse the repository at this point in the history