Fixed clear-text logging of all password-like properties in API/HMC log #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/fix-ssc-master-pw
branch
4 times, most recently
from
b88441d
to
f2d096e
Compare
andy-maier
changed the title
Details: * Reworked the @logged_api_call decorator to get optional parameters for specifying properties ot be blanked out in the API logging. This required significant reimplementation of that decorator and the functions it calls. * Fixed the clear-text logging of all password-like properties in the API logging by using this new capability of the @logged_api_call decorator. * Fixed the clear-text logging of all password-like properties in the HMC logging by blanking them out in the Session.post() method. * Added unit test cases for the blanked-out API logging, in the test_logging.py module. * Added unit test cases for the blanked-out API logging, in all test modules for those resources that have blanked-out properties. * Improved the checking in the unit test cases for API logging, to check the function name, args, kwargs and return value in the log messages. Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/fix-ssc-master-pw
branch
from
f2d096e
to
a269ab8
Compare
simon-spinner
approved these changes
Nov 28, 2024
EdGue42
approved these changes
Nov 28, 2024
Signed-off-by: Andreas Maier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, see the commit message.
Tested in addition, using this version of zhmcclient: