Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about implementation of graph convolution #1

Open
tomato18463 opened this issue Mar 25, 2023 · 2 comments
Open

A question about implementation of graph convolution #1

tomato18463 opened this issue Mar 25, 2023 · 2 comments

Comments

@tomato18463
Copy link

tomato18463 commented Mar 25, 2023

Hi,

Thanks for sharing your code! I have got a question about the implementaion of graph convolution in this code.

According to here, your graph is normalized column-wise. But the matrix multiplication here seems to use each row of your graph to weight the features of different node and sum it together. I am not sure if it is correct. It seems the right way is to use each column of your graph to weight-and-sum the features, so that the sum of weights is one whatever the number of neighbours? Is there something wrong in my understanding here?

Thank you!

@zhysora
Copy link
Owner

zhysora commented Mar 27, 2023

Thanks for your good question.

These parts of codes are borrowed from this repo. You can make an issue there for a better answer.

@Sfadingz
Copy link

The normalized graph A is added to x1 in the matrix multiplication you mentioned. Based on what I learn about torch.einsum( ), it seems to use each column of x1 to multiply each column of x3, so I think it is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants