Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support caching of async completion and cache completion #513

Merged
merged 14 commits into from
Sep 5, 2023
Merged

Support caching of async completion and cache completion #513

merged 14 commits into from
Sep 5, 2023

Conversation

Rested
Copy link
Contributor

@Rested Rested commented Aug 12, 2023

#415 addresses some of the comments here

@sre-ci-robot
Copy link
Collaborator

Welcome @Rested! It looks like this is your first PR to zilliztech/GPTCache 🎉

@mergify mergify bot added the needs-dco label Aug 12, 2023
@mergify mergify bot added dco-passed and removed needs-dco labels Aug 12, 2023
@codecov
Copy link

codecov bot commented Aug 12, 2023 •
edited
Loading

Codecov Report

Merging #513 (6fc861e) into dev (a3328f2) will decrease coverage by 0.96%.
Report is 13 commits behind head on dev.
The diff coverage is 31.37%.

❗ Current head 6fc861e differs from pull request most recent head 69f8378. Consider uploading reports for the commit 69f8378 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #513      +/-   ##
==========================================
- Coverage   94.20%   93.24%   -0.96%     
==========================================
  Files          94       94              
  Lines        3898     3967      +69     
==========================================
+ Hits         3672     3699      +27     
- Misses        226      268      +42
Files Changed Coverage Δ
gptcache/adapter/openai.py 80.95% <29.16%> (-13.68%) ⬇️
gptcache/adapter/adapter.py 87.71% <66.66%> (-0.34%) ⬇️

... and 7 files with indirect coverage changes

@SimFG SimFG changed the base branch from main to dev August 12, 2023 03:52
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Rested
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added needs-dco and removed dco-passed labels Aug 16, 2023
SimFG and others added 9 commits August 16, 2023 03:53
@SimFG @Rested
Use the old version for the chromadb (zilliztech#492)
e16568b 
Signed-off-by: SimFG <[email protected]>
Signed-off-by: Reuben Thomas-Davis <[email protected]>
@pranaychandekar @Rested
added support for weaviate vector databse (zilliztech#493)
a17b710 
* added support for weaviate vector databse

Signed-off-by: pranaychandekar <[email protected]>

* added support for in local db for weaviate vector store

Signed-off-by: pranaychandekar <[email protected]>

* added unit test case for weaviate vector store

Signed-off-by: pranaychandekar <[email protected]>

* resolved unit test case error for weaviate vector store

Signed-off-by: pranaychandekar <[email protected]>

* increased code coverage
resolved pylint issues

pylint: disabled C0413

Signed-off-by: pranaychandekar <[email protected]>

---------

Signed-off-by: pranaychandekar <[email protected]>
Signed-off-by: Reuben Thomas-Davis <[email protected]>
@SimFG @Rested
Update the version to 0.1.37 (zilliztech#494)
05e3fc8 
Signed-off-by: SimFG <[email protected]>
Signed-off-by: Reuben Thomas-Davis <[email protected]>
@Rested
✨ support caching of async completion and cache completion
42f2ae5 
Signed-off-by: Reuben Thomas-Davis <[email protected]>
@Rested
✨ add streaming support for chatcompletion
91752e1 
Signed-off-by: Reuben Thomas-Davis <[email protected]>
@Rested
✅ improve test coverage and formatting
f10eab3 
Signed-off-by: Reuben Thomas-Davis <[email protected]>
@Rested
✨ support caching of async completion and cache completion
bb6e53d 
Signed-off-by: Reuben Thomas-Davis <[email protected]>
@Rested
✨ add streaming support for chatcompletion
1733b69 
Signed-off-by: Reuben Thomas-Davis <[email protected]>
@Rested
✅ improve test coverage and formatting
0dab42e 
Signed-off-by: Reuben Thomas-Davis <[email protected]>
@mergify mergify bot added dco-passed and removed needs-dco labels Aug 16, 2023
@Rested
correct merge duplication
6fc861e 
Signed-off-by: Reuben Thomas-Davis <[email protected]>
@SimFG
Copy link
Collaborator

SimFG commented Aug 16, 2023

Thank you for your patience with this pr

@Rested
correct update cache callback
003884d 
Signed-off-by: Reuben Thomas-Davis <[email protected]>
@Rested
add additional tests for improved coverage
a7b6887 
Signed-off-by: Reuben Thomas-Davis <[email protected]>
@Rested
remove redundant param in docstring
69f8378 
Signed-off-by: Reuben Thomas-Davis <[email protected]>
@Rested
Copy link
Contributor Author

Rested commented Aug 18, 2023

Not sure what's up with the last ci fail

@SimFG SimFG merged commit d19bf74 into zilliztech:dev Sep 5, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxie cxie Awaiting requested review from cxie

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

Assignees
No one assigned
Labels
dco-passed size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rested @sre-ci-robot @SimFG @pranaychandekar