Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for lancedb as vectordb #644

Merged
merged 10 commits into from
Sep 6, 2024
Merged

support for lancedb as vectordb #644

merged 10 commits into from
Sep 6, 2024

Conversation

akashAD98
Copy link

added support for lancedb

@mergify mergify bot added the dco-passed label Sep 2, 2024
@akashAD98
Copy link
Author

/assign @xiaofan-luan

@SimFG
Copy link
Collaborator

SimFG commented Sep 4, 2024

please set the target branch to the dev branch, and fix the lint error

@SimFG SimFG assigned SimFG and unassigned xiaofan-luan Sep 4, 2024
@akashAD98 akashAD98 changed the base branch from main to dev September 4, 2024 06:45
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akashAD98
To complete the pull request process, please ask for approval from simfg after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added needs-dco and removed dco-passed labels Sep 4, 2024
@akashAD98 akashAD98 force-pushed the feature/vectorstore-lancedbnews branch 3 times, most recently from d843425 to 72cf45e Compare September 4, 2024 08:35
@mergify mergify bot added dco-passed and removed needs-dco labels Sep 4, 2024
@akashAD98
Copy link
Author

akashAD98 commented Sep 4, 2024 •
edited
Loading

@SimFG i did changes please check it. t
hank you for your time

@mergify mergify bot added needs-dco and removed dco-passed labels Sep 5, 2024
SimFG and others added 9 commits September 5, 2024 19:30
@SimFG @akashAD98
Remove the Weaviate unit test
3e76abc 
Signed-off-by: SimFG <[email protected]>
Signed-off-by: akashAD98 <[email protected]>
@leio10 @akashAD98
fix: avoid loading redis if not needed
f2168dd 
Signed-off-by: akashAD98 <[email protected]>
@SimFG @akashAD98
Update the version to 0.1.43
86bdae5 
Signed-off-by: SimFG <[email protected]>
Signed-off-by: akashAD98 <[email protected]>
@SimFG @akashAD98
add the note for the gptcache api
88b82ba 
Signed-off-by: akashAD <[email protected]>
Signed-off-by: akashAD98 <[email protected]>
@SimFG @akashAD98
Fix the nil memory eviction when using the init_similar_cache method
d8bcf7f 
Signed-off-by: SimFG <[email protected]>
Signed-off-by: akashAD <[email protected]>
Signed-off-by: akashAD98 <[email protected]>
@SimFG @akashAD98
Update the version to 0.1.44
87512f6 
Signed-off-by: SimFG <[email protected]>
Signed-off-by: akashAD <[email protected]>
Signed-off-by: akashAD98 <[email protected]>
@akashAD98
added support for lancedb as vectorstore
ec37888 
Signed-off-by: akashAD <[email protected]>
Signed-off-by: akashAD98 <[email protected]>
@akashAD98
Fix pylint issues and improve codes structure
c36a143 
Signed-off-by: akashAD <[email protected]>
Signed-off-by: akashAD98 <[email protected]>
@akashAD98
refactor & pylint fix code
e9b9dd1 
Signed-off-by: akashAD98 <[email protected]>
@akashAD98 akashAD98 force-pushed the feature/vectorstore-lancedbnews branch from 9a01d92 to e9b9dd1 Compare September 5, 2024 14:00
@mergify mergify bot added dco-passed and removed needs-dco labels Sep 5, 2024
@akashAD98
Copy link
Author

@SimFG can you please help me in this pr? your help would be appreciated thanks.

@SimFG
Copy link
Collaborator

SimFG commented Sep 6, 2024

@akashAD98 got it, i will check it

@SimFG
Copy link
Collaborator

SimFG commented Sep 6, 2024

you can try to execute make pylint_check to find the lint error

@akashAD98
pylint issue fixing
4ed408f 
Signed-off-by: akashAD98 <[email protected]>
@akashAD98
Copy link
Author

akashAD98 commented Sep 6, 2024 •
edited
Loading

you can try to execute make pylint_check to find the lint error

yes actually I used it still not sure why its missing even I did respective changes @SimFG

@SimFG SimFG merged commit 7492681 into zilliztech:dev Sep 6, 2024
4 of 6 checks passed
@akashAD98 akashAD98 deleted the feature/vectorstore-lancedbnews branch September 6, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxie cxie Awaiting requested review from cxie

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

Assignees

@SimFG SimFG

Labels
dco-passed size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akashAD98 @SimFG @sre-ci-robot @xiaofan-luan @leio10