Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase timeout #390

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

alwayslove2013
Copy link
Collaborator

Increase the timeout limit significantly to reduce the risk of re-testing for first-time users, while allowing advanced users the option to set this parameter.

In the future, consideration can be given to exposing the timeout parameter in the web UI.

Signed-off-by: min.tian <[email protected]>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alwayslove2013, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn XuanYang-cn merged commit 369f3c6 into zilliztech:main Oct 29, 2024
4 checks passed
@alwayslove2013 alwayslove2013 deleted the update_timeout branch October 29, 2024 08:50
Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alwayslove2013 @XuanYang-cn Let's make it tunable from the UI. We can only put the results satisfy the default value on the leaderboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants