Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease knowhere threads scheduling priority #17

Closed
wants to merge 1 commit into from

Conversation

zhengbuqian
Copy link
Collaborator

Force threads used by knowhere thread pool to be scheduled using FIFO and lowest priority, so that knowhere won't consume all cpu cycles and stall other threads.

Note that these changes will be effective only if ran by root. Running codes in this PR with non-root privilege will silently fail and will not crash the program.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhengbuqian
Copy link
Collaborator Author

/kind improvement

@mergify
Copy link

mergify bot commented Aug 17, 2023

⚠️ The sha of the head commit of this PR conflicts with #19. Mergify cannot evaluate rules on this PR. ⚠️

@zhengbuqian zhengbuqian deleted the lower-kw-prio branch August 21, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants