From 31e08ce7ff2b18bbdeacabeebc3b820f537b4e22 Mon Sep 17 00:00:00 2001
From: "edward.zeng" <jie.zeng@zilliz.com>
Date: Mon, 18 Mar 2024 18:38:58 +0800
Subject: [PATCH] remove minio gateway (#77)

Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
---
 charts/milvus/Chart.yaml  |  2 +-
 charts/milvus/README.md   | 22 +++++++++++++++++++++-
 charts/milvus/values.yaml |  6 ------
 3 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/charts/milvus/Chart.yaml b/charts/milvus/Chart.yaml
index 3a930e1..2963667 100644
--- a/charts/milvus/Chart.yaml
+++ b/charts/milvus/Chart.yaml
@@ -3,7 +3,7 @@ name: milvus
 appVersion: "2.3.12"
 kubeVersion: "^1.10.0-0"
 description: Milvus is an open-source vector database built to power AI applications and vector similarity search.
-version: 4.1.25
+version: 4.1.26
 keywords:
   - milvus
   - elastic
diff --git a/charts/milvus/README.md b/charts/milvus/README.md
index 9732f0c..a33bfb7 100644
--- a/charts/milvus/README.md
+++ b/charts/milvus/README.md
@@ -212,6 +212,27 @@ In case you want to use a different `secretName` or mount path inside pod, modif
     name: milvus-tls
 ```
 
+## Milvus with External Object Storage
+
+As of https://github.com/minio/minio/releases/tag/RELEASE.2022-10-29T06-21-33Z, the MinIO Gateway and the related filesystem mode code have been removed. It is now recommended to utilize the `externalS3` configuration for integrating with various object storage services. Notably, Milvus now provides support for popular object storage platforms such as AWS S3, GCP GCS, Azure Blob, Aliyun OSS and Tencent COS. 
+
+The recommended configuration option for `externalS3.cloudProvider` includes the following choices: `aws`, `gcp`, `azure`, `aliyun`, and `tencent`. Here's an example to use AWS S3 for Milvus object storage:
+
+```
+minio:
+  enabled: false
+externalS3:
+  enabled: true
+  cloudProvider: aws
+  host: s3.aws.com
+  port: 443
+  useSSL: true
+  bucketName: <bucket-name>
+  accessKey: <s3-access-key>
+  secretKey: <s3-secret-key>
+```
+
+
 ## Uninstall the Chart
 
 ```bash
@@ -294,7 +315,6 @@ The following table lists the configurable parameters of the Milvus Service and
 | `externalS3.iamEndpoint`                  | The IAM endpoint of  the external S3 | ``                                                |
 | `externalS3.region`                  | The region of  the external S3 | ``                                                |
 | `externalS3.useVirtualHost`                  | If true, the external S3 whether use virtual host bucket mode | ``                                                |
-| `externalGcs.bucketName`                  | The Bucket Name of the external GCS. Requires GCS gateway to be enabled in the minIO configuration | `unset`                                                |
 | `externalEtcd.enabled`                    | Enable or disable external Etcd               | `false`                                                 |
 | `externalEtcd.endpoints`                  | The endpoints of the external etcd            | `{}`                                                    |
 | `externalPulsar.enabled`                  | Enable or disable external Pulsar             | `false`                                                 |
diff --git a/charts/milvus/values.yaml b/charts/milvus/values.yaml
index ad6e34f..8a99f46 100644
--- a/charts/milvus/values.yaml
+++ b/charts/milvus/values.yaml
@@ -505,12 +505,6 @@ minio:
     requests:
       memory: 2Gi
 
-  gcsgateway:
-    enabled: false
-    replicas: 1
-    gcsKeyJson: "/etc/credentials/gcs_key.json"
-    projectId: ""
-
   service:
     type: ClusterIP
     port: 9000