-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π±π₯β¨ Utility
: AWS::S3
#1430
Comments
I don't see the need to have AWS S3 as a configurable Utility for now, or maybe ever. I don't think anyone running a Space needs to be bothered to have their own AWS account, and a hypothetical Neighborhood operator already can configure AWS for their Neighborhood via env variables. Having a per-space bucket, while nice, doesn't seems necessary for the use cases that we have for now (Spotlight, and soon Marketplace product photos and Journal attachments), because the amount of storage use that these features generate is unlikely to be so big that we'll need to figure out how to pass through the costs to the Space owners. At least not in the short or mid term. We can organize objects in S3 into sets that can be easily mapped to a space by using folders and/or a common naming schema (e.g. by having a folder name being the space id, or by always having the space id in the object name). Although with our current level of non-usage, I'd argue that this is also not really a requirement or a blocker for adding product photos. |
To be clear, a
I think on the 10-month time-scale, one-bucket-per-neighborhood is fine so long as we have a way to safely navigate:
|
- #1430 - #1428 - Pulled from https://github.com/libvips/ruby-vips/blob/master/.github/workflows/test.yml I'm not particularly pleased with this, but I didn't find a github action; and I'm not entirely sure why the test passes locally but not on CI.
- #1430 - #1428 - Pulled from https://github.com/libvips/ruby-vips/blob/master/.github/workflows/test.yml I'm not particularly pleased with this, but I didn't find a github action; and I'm not entirely sure why the test passes locally but not on CI.
- #1430 - #1428 - Pulled from https://github.com/libvips/ruby-vips/blob/master/.github/workflows/test.yml I'm not particularly pleased with this, but I didn't find a github action; and I'm not entirely sure why the test passes locally but not on CI.
- #1430 - #1428 - Pulled from https://github.com/libvips/ruby-vips/blob/master/.github/workflows/test.yml I'm not particularly pleased with this, but I didn't find a github action; and I'm not entirely sure why the test passes locally but not on CI.
β¦1494) * `Marketplace`: Install `libvips` for testing `Product::Photo`s - #1430 - #1428 - Pulled from https://github.com/libvips/ruby-vips/blob/master/.github/workflows/test.yml
Utilities
Β #252Used By
Marketplace
:Product::Photo
sΒ #1428Gizmo
:Journal
Β journal#1Gizmo
:Spotlight
Β #201Use Cases
Contributor
may use standardActiveStorage
syntax to enableUploads
onFurniture
Rough Plan
We probably want each
Space
to have their own S3 bucket. However, we don't want each client to need an AWS account, so we are hoping to have a Neighborhood levelAWS
(orVultr
or insert provider here configuration) which we pass through the costs to the individual Space owners.There's a doc on how to set up ActiveStorage so we can upload files to a Space-by-Space S3 Bucket: https://blog.geogo.in/activestorage-dont-limit-yourself-in-a-single-bucket-4af165adbf84
The text was updated successfully, but these errors were encountered: