Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photographer Grants Permissions after Upgrading iOS versions #21

Open
5 tasks
zspencer opened this issue Aug 20, 2020 · 1 comment
Open
5 tasks

Photographer Grants Permissions after Upgrading iOS versions #21

zspencer opened this issue Aug 20, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@zspencer
Copy link
Member

zspencer commented Aug 20, 2020

There appear to be cases where we do not check to verify if the correct permissions have been set, which results in people who have been using ShakeIt for a long time to lose photographs.

See: #13 (comment)

This Issue May Be Closed When

  • The permission checking code gets executed every time the application launches
  • The take photo permission checking code does not prompt for permissions if it has the ability to take photos
  • The save photo permission checking code does not prompt for permissions if it has the ability to save photos
  • The share permission checking code does not prompt for permissions if it has the ability to share
  • The feature definition and scenario is added to the features/granting-permissions.feature

Feature Definition (features/granting-permissions.feature)

Feature: Granting Permissions
  In order to take and save photos
  I want to grant the correct permissions to ShakeIt Photo

  Scenario: Photographer Grants Permissions after Upgrading iOS versions
    Given a Photographer with a device running a version of iOS with old permission structures
    When the device is upgraded to a version of iOS which requires different photo and camera access
    Then the Photographer is prompted to grant photo access
    And the Photographer is prompted to grant camera access
@zspencer zspencer added enhancement New feature or request test Hone your test definition or automation skills! labels Aug 20, 2020
@zspencer zspencer added bug Something isn't working and removed enhancement New feature or request test Hone your test definition or automation skills! labels Apr 18, 2021
@zspencer zspencer added this to the ShakeItPhoto 3.3.0 milestone Apr 18, 2021
@zspencer
Copy link
Member Author

Does this seem like something worth doing as part of the 3.3.0 release; or a 3.2.7 bugfix release? Or has this been fixed already? I know we did some explorations around checking and requesting permissions more explicitly, but I don't recall if we actually "fixed" it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants