Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-trivial lambdas in Scala-style rendering format #490

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from
Draft

Support non-trivial lambdas in Scala-style rendering format #490

wants to merge 14 commits into from

Conversation

varshith257
Copy link

@varshith257 varshith257 commented Nov 8, 2024 •
edited
Loading

Fixes #384

@varshith257
Copy link
Author

@pshirshov I have this approach in my mind to support nontrivial lamdas but it still emitting the same. Any suggestions for it?

pshirshov
pshirshov requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@pshirshov pshirshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, thank you! But I think it should be done on Ref level

@pshirshov
Copy link
Member 

 [error] /home/runner/work/izumi-reflect/izumi-reflect/izumi-reflect/izumi-reflect/src/main/scala/izumi/reflect/macrortti/LightTypeTag.scala:285:6: illegal start of simple expression
[error] =    case LightTypeTagRef.FullReference(_, args, _) if args.nonEmpty =>

I guess it might be a good idea to build locally first. sbt +clean +test:compile +test

@varshith257
Copy link
Author

varshith257 commented Nov 9, 2024 •
edited
Loading

Ok, I will move these changes to LightTypeTagRef.scala

@pshirshov
Copy link
Member

@varshith257 : could you tell me if you still wish to complete this? May I help you somehow?

@varshith257
Copy link
Author

@pshirshov Yeah! I will push to complete it by EOD and will reachout you if I get struck anywhere

@varshith257
Copy link
Author

Just I needed to push the changes to ref and I exported there but a minor fixes needed of there for accessing shortname etc..as they are throwing few compilation errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshirshov pshirshov pshirshov requested changes

@neko-kai neko-kai Awaiting requested review from neko-kai neko-kai will be requested when the pull request is marked ready for review neko-kai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support non-trivial lambdas in Scala-style rendering format
2 participants
@varshith257 @pshirshov