Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opacity of opaque types on Scala 3 #468

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

neko-kai
Copy link
Member

@neko-kai neko-kai commented Jul 1, 2024

For opaque type S = String generate tag S instead of S::<String..String>

Breaks compatibility with previously generated tags for opaque types on Scala 3

/claim #472

lol lmao

For `opaque type S = String` generate tag `S` instead of `S::<String..String>`

Breaks compatibility with previously generated tags
@neko-kai
Copy link
Member Author

neko-kai commented Jul 1, 2024

Not sure how to release this, this will break binary compatibilty for opaque types if tags for them are generated in libraries.

@kitlangton I wonder how many libraries use opaque types with ZIO environment right now?

@kyri-petrou
Copy link

kyri-petrou commented Jul 26, 2024

Not sure how to release this, this will break binary compatibilty for opaque types if tags for them are generated in libraries

Is it binary compatibility that it's breaking, or it's not backwards compatible as opaque types will now produce a different tag?

@neko-kai
Copy link
Member Author

@kyri-petrou

Is it binary compatibility that it's breaking, or it's not backwards compatible as opaque types will now produce a different tag?

Second. Which is also the first, because if a tag is contained in a library, it will not match with a tag for the same type generated in user code.

@neko-kai neko-kai marked this pull request as ready for review September 12, 2024 11:36
Copy link

algora-pbc bot commented Nov 8, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@neko-kai neko-kai merged commit a87d9ac into develop Nov 8, 2024
20 checks passed
@neko-kai neko-kai deleted the feature/opaque-types-fix branch November 8, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants