Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config from exception when Hikari data source can't be created #2503

Merged
merged 9 commits into from
Sep 17, 2023

Conversation

mdulac
Copy link
Contributor

@mdulac mdulac commented May 31, 2022

Problem

When creating a DataSource with DataSourceLayer.fromConfig with a wrong configuration (rejected by the server), the exception thrown contains all the configuration serialised and so could contain the password.
By default, if we just want to log what comes from Quill, the password could be leaked clear.

Capture d’écran 2022-05-31 à 22 19 02

Solution

I removed the config serialised in the exception message to let the application log what it's relevant.

Notes

Additional notes.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@mdulac mdulac marked this pull request as ready for review May 31, 2022 20:43
@guizmaii guizmaii merged commit 9b6e8bb into zio:master Sep 17, 2023
18 checks passed
@guizmaii
Copy link
Member

@mdulac Thanks for your contribution! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants