Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respekt default annotations on primitive schemas #715

Closed
987Nabil opened this issue Aug 3, 2024 · 4 comments · Fixed by #733
Closed

Respekt default annotations on primitive schemas #715

987Nabil opened this issue Aug 3, 2024 · 4 comments · Fixed by #733
Labels
💎 Bounty 💰 Rewarded

Comments

@987Nabil
Copy link
Contributor

987Nabil commented Aug 3, 2024

Currently, Schema[Int].annotate(fieldDefaultValue(5)) would result in a schema that would return 0 for a call of defaultValue instead of 5. We should fix this.
Adding validation annotations for primitive schemas works for example.
@jdegoes
Copy link
Member

jdegoes commented Aug 29, 2024

/bounty $125

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Aug 29, 2024 •
edited
Loading

💎 $125 bounty • ZIO

Steps to solve:

  1. Start working: Comment /attempt #715 with your implementation plan
  2. Submit work: Create a pull request including /claim #715 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio-schema!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @987Nabil #733

987Nabil added a commit to 987Nabil/zio-schema that referenced this issue Aug 30, 2024
@987Nabil
Schema.Primitive respects default annotation for defaultValue (zio#715)
e7b2559 
Add Schema.defaultValue to set default of a schema
@987Nabil 987Nabil mentioned this issue Aug 30, 2024
Merged
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Aug 30, 2024

💡 @987Nabil submitted a pull request that claims the bounty. You can visit your bounty board to reward.

987Nabil added a commit to 987Nabil/zio-schema that referenced this issue Sep 1, 2024
@987Nabil
Schema.Primitive respects default annotation for defaultValue (zio#715)
66854c7 
Add `Schema#default` to set default of a schema
jdegoes pushed a commit that referenced this issue Sep 3, 2024
@987Nabil
Schema.Primitive respects default annotation for defaultValue (#715) (#…
fc1b601 
…733)

Add `Schema#default` to set default of a schema
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Sep 3, 2024

🎉🎈 @987Nabil has been awarded $125! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty 💰 Rewarded
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Schema.Primitive respects default annotation for defaultValue (#715) 987Nabil/zio-schema
2 participants
@jdegoes @987Nabil