-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate into ZIO Logging & Metrics #558
Comments
These goals sound incredible. What's less clear to me is how complete the coverage is in native ZIO capabilities. I know ZIO has some "tracing" capabilities but am much less clear what they are and how well they map to the equivalent Otel concepts. @jdegoes any suggestions as to how we can get starting mapping these capabilities? |
I'm integrating Baggage with ZIO log annotations in this PR: #662 |
is there any update on this? |
Hey! I'm still working on adding metrics support in general. After this, I believe mapping ZIO metrics to OTEL metrics should be possible. The only part that was done long ago is mapping ZIO annotations to OpenTelemetry baggage. It is not reflected in docs, though, but you can check out the source code at https://github.com/zio/zio-telemetry/blob/series/2.x/opentelemetry/src/main/scala/zio/telemetry/opentelemetry/baggage/Baggage.scala and find some examples in https://github.com/zio/zio-telemetry/blob/series/2.x/opentelemetry/src/test/scala/zio/telemetry/opentelemetry/baggage/BaggageTest.scala#L89. I was researching how to map ZIO logging and I don't think it is doable since there is no way to extract the original log message. I hope I am wrong about it. |
@grouzen thanks for the update. I'm trying to understand how does this work with something like |
@omidb Yes, your solution is fine. As I said in the message above, there is no integration with ZIO logging at the moment and I don't think it is possible to make it happen due to technical reasons. |
Also, I've got another idea that we can potentially implement some sort of |
@omidb Hello! The support for the Logs signal has been added recently, you can find it in the latest 3.0.0-RC-18 release version. |
Support for metrics has been added at #790 |
@grouzen thanks for the update. we will check this out. is there an example or doc? |
@omidb Of course! The docs were updated as well: https://zio.dev/zio-telemetry/opentelemetry/#logging |
@grouzen thanks. not related to this issue, I was wondering what do u use for visualizing all the traces, logs, metrics? do u have a favorite all in one ecosystem? |
@grouzen we use honeycomb internally. I want to find a good open source platform that does logging, tracing and metric all together. https://skywalking.apache.org/ looks interesting but it's not OTEL first and seems I have to go through hoops to get it to work. |
@omidb Sorry, do you mean Honeycomb doesn't provide a UI for all metrics? Yeah, Apache Skywalking could be a good option, but I also decided not to spend time on it for the same reason as yours. |
@grouzen Honeycomb is limited to tracing and not a good log explorer. We can continue this discussion on Discord :) |
Closing this one since all goals have been achieved. |
The goal of ZIO Telemetry should be to seamlessly add OpenTelemetry support via ZIO's own built-in logging and metrics, adding integration points as necessary and useful.
TODO
The text was updated successfully, but these errors were encountered: