Merge pull request #3 from zirkelc/fix-deserialize-payload

fix: check content type with startswith
zirkelc · Oct 7, 2024 · 79bcee7 · 79bcee7
2 parents 477c2d4 + 3fa55e9
commit 79bcee7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/eleven-tigers-double.md b/.changeset/eleven-tigers-double.md
@@ -0,0 +1,5 @@
+---
+"middy-store-s3": patch
+---
+
+fix: use startsWith instead of equals to check content type
diff --git a/packages/store-s3/src/store.ts b/packages/store-s3/src/store.ts
@@ -203,14 +203,15 @@ export class S3Store implements StoreInterface<unknown, S3Reference> {
 	): Promise<unknown> {
 		const { Body, ContentType } = result;
 
-		if (ContentType === "text/plain") {
+		// TODO check for charset encoding
+		if (ContentType?.startsWith("text/plain")) {
 			const payload = await Body?.transformToString("utf-8");
 			if (payload === undefined) throw new Error("Payload is undefined");
 
 			return payload as unknown;
 		}
 
-		if (ContentType === "application/json") {
+		if (ContentType?.startsWith("application/json")) {
 			const payload = await Body?.transformToString("utf-8");
 			if (payload === undefined) throw new Error("Payload is undefined");