feat: add typ:JWT header to tokens #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #435 +/- ##
=======================================
Coverage 53.29% 53.29%
=======================================
Files 74 74
Lines 5727 5727
=======================================
Hits 3052 3052
Misses 2415 2415
Partials 260 260
|
muhlemmer
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Alternatively, the Storage interface could be enhanced to allow user control over JWT headers.
For now this solution is fine. As RFC 7519, section-5.1 mentions, if provided it must be set to JWT. Allowing users to change this is asking for trouble. (And oidc doesn't support anything else than JWT anyway).
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny change adds a "typ":"JWT" header to the tokens created.
Alternatively, the Storage interface could be enhanced to allow user control over JWT headers.
Resolves #434