Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert state changes for script tests #65

Open
JohnGuilding opened this issue Dec 10, 2024 · 3 comments · May be fixed by #70
Open

Assert state changes for script tests #65

JohnGuilding opened this issue Dec 10, 2024 · 3 comments · May be fixed by #70

Comments

@JohnGuilding
Copy link
Collaborator

As per the foundry docs, tests for deployment scripts should assert on the state changes made by the script. This issue is concerned with modifying the following tests to assert against all state changes in our scripts including branching logic:

  1. Assert against state changes including:
  • The specific contracts are deployed
  • Use require statements to assert that the expected address is correct, this work would include calculating expected addresses: require(computedAddress == deployedAddress, "address mismatch")
  1. Ensure all branching logic is tested not just a single happy path
@mahmudsudo
Copy link

hi , i am applying for the smart contract role and will be taking on this issue

@JohnGuilding
Copy link
Collaborator Author

Hey @mahmudsudo, great

@mahmudsudo mahmudsudo linked a pull request Dec 25, 2024 that will close this issue
@mahmudsudo
Copy link

i have also sent the email also as required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants