Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark for Android #266

Closed
vivianjeng opened this issue Dec 3, 2024 · 2 comments · Fixed by #283
Closed

Benchmark for Android #266

vivianjeng opened this issue Dec 3, 2024 · 2 comments · Fixed by #283
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@vivianjeng
Copy link
Collaborator

Problem

Now we have benchmark results for iOS and Mac here: https://zkmopro.org/docs/performance/
and here https://github.com/zkmopro/mopro?tab=readme-ov-file#performance
but Android benchmark results are missing

Details

We can have a simplified result table like this

Circuits snarkjs groth16 fullprove mopro (rust-witness + ark-works) witnesscalc + rapidsnark
Keccak256 - ms - ms - ms
SHA256 - ms - ms - ms
RSA - ms - ms - ms
Semaphore - ms - ms - ms
Anon Aadhaar - ms - ms - ms

If there is a result for separating witness generation + proof generation it would be great

Acceptance criteria

Update benchmark result in README and performance page
(if there is an app like https://github.com/zkmopro/benchmark-app for Android would be great)

Next steps (optional)

Describe the subsequent actions to be taken.

@vivianjeng vivianjeng added documentation Improvements or additions to documentation good first issue Good for newcomers labels Dec 3, 2024
@vivianjeng
Copy link
Collaborator Author

vivianjeng commented Dec 26, 2024

Benchmark on Samsung S23U (2023)

Circuits snarkjs groth16 fullprove mopro (rust-witness + ark-works) witnesscalc + rapidsnark
Keccak256 - ms 2550 ms 867 ms
SHA256 - ms 1730 ms 252 ms
RSA - ms 9530 ms 1100 ms
Semaphore - ms 331 ms 188 ms
Anon Aadhaar - ms 30290 ms 3883 ms

Repo: https://github.com/zkmopro/android-benchmark-app
Updated rapidsnark: https://github.com/iden3/android-rapidsnark

@vivianjeng
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant