Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC8813 is not recognized as a valid lint source from the CLI #879

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

christopher-henderson
Copy link
Member

@christopher-henderson christopher-henderson commented Sep 8, 2024

This is an issue in the CLI frontend. The lint source does indeed run when zlint is invoked with a filter that does not explicitly refer to RFC8813. The following will run RFC8813 successfully.

./zlint -excludeSources CABF_BR github.com

However, the following will simply error out at the CLI

./zlint -excludeSources RFC8813 github.com
FATA[0000] invalid -excludeSources: unknown lint source in list: "RFC8813" 
exit status 1

Issues such as this are found about 1-2 times per year, which is too much. I've made an issue for myself (#878) that this codebase would benefit from integration tests with the frontend.

Thank you @yukoori for submitting the issue!

@zakird zakird merged commit 372cdc6 into master Sep 8, 2024
8 checks passed
@zakird zakird deleted the fix_rfx8813 branch September 8, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants