Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification UI Enhancements #603

Closed
5 tasks done
cstiens opened this issue May 11, 2018 · 2 comments
Closed
5 tasks done

Verification UI Enhancements #603

cstiens opened this issue May 11, 2018 · 2 comments

Comments

@cstiens
Copy link
Collaborator

cstiens commented May 11, 2018

@tladesignz Here is a comprehensive list for the UI tuning for the verification view. I'm going to close the other ticket (#578) where we have feedback dispersed.

  • Text for 'Make sure the codes match...' cuts off on iPhone 6 still. It looks great on the iPad and iPhone 7 though.

  • For expired codes, since there is no action the user to take (for their friend's expired code), please remove the toggle if the code is expired. I think that it's disabled right now, but it looks like it's just off. So, let's remove it all together only if the code is expired.

  • Update icons --
    for trusted, use green badge with the check (attached in @3x size and .pdf)
    for untrusted, use red badge with exclamation point (attached in @3x size and .pdf)

badges_v2.zip

  • Divide OMEMO and OTR keys and add sub header (see mockup below)

  • If there are no trusted codes for a contact, change text to 'No Zom codes for [name].'

verification-enhance

@cstiens cstiens added this to the Final Spring Sprint milestone May 11, 2018
tladesignz added a commit to tladesignz/Zom-iOS that referenced this issue May 14, 2018
tladesignz added a commit to tladesignz/Zom-iOS that referenced this issue May 14, 2018
tladesignz added a commit to tladesignz/Zom-iOS that referenced this issue May 14, 2018
tladesignz added a commit to tladesignz/Zom-iOS that referenced this issue May 14, 2018
… keys AND no untrusted NEW keys for a buddy.
tladesignz added a commit to tladesignz/Zom-iOS that referenced this issue May 14, 2018
…tually get a chance to understand, why there are different types of fingerprints.
@tiffrobo
Copy link

tiffrobo commented May 31, 2018

Looking good here. All the above actions are in.
@tladesignz @cstiens Should the toggles be available to turn on and off? Right now they are usable.

Device: iPhone 7, iPad
OS: 11.2.2, 10.3.2
App version: build 131

@tiffrobo
Copy link

tiffrobo commented Jun 4, 2018

Currently, want the toggles to be usable so I'll close this ticket!

@tiffrobo tiffrobo closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants