New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash login password before comparing it to the stored password #52

Open

zsoerenm opened this issue Oct 27, 2011 · 3 comments

zsoerenm commented Oct 27, 2011

The password is compared to the stored password, before the it's hashed:
https://github.com/zombor/Auto-Modeler/blob/master/classes/auth/automodeler/orm.php#L89

Shouldn't it be like this?:
https://github.com/kohana/auth/blob/3.2/master/classes/kohana/auth/file.php#L40

Owner

zombor commented Oct 27, 2011

Yes: https://github.com/zombor/Auto-Modeler/blob/develop/classes/auth/automodeler/orm.php#L89

zombor closed this as completed

Author

zsoerenm commented Oct 27, 2011

Alright that's because of api change from 3.1 -> 3.2

Author

zsoerenm commented Oct 27, 2011

Auths hash function only accepts 1 parameter, it gets the salt from the config.

https://github.com/zombor/Auto-Modeler/blob/develop/classes/auth/automodeler/orm.php#L88

zombor reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment