Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating test with empty domain gives confusing error message #1032

Open
matsduf opened this issue Jun 3, 2022 · 0 comments · Fixed by #1132
Open

Creating test with empty domain gives confusing error message #1032

matsduf opened this issue Jun 3, 2022 · 0 comments · Fixed by #1132
Labels
T-Bug Type: Bug in software or error in test case description
Milestone

Comments

@matsduf
Copy link
Contributor

matsduf commented Jun 3, 2022

An empty domain is not allowed and should not be allowed, but it would be good if the error message says that the domain name must not be empty, not giving an incorrect message that the characters are not supported.

{
  "jsonrpc": "2.0",
  "id": 1,
  "params": {
    "domain": ""
  },
  "method": "start_domain_test"
}
{
  "jsonrpc": "2.0",
  "id": 1,
  "error": {
    "data": [
      {
        "path": "/domain",
        "message": "The domain name character(s) are not supported"
      }
    ],
    "message": "Invalid method parameter(s).",
    "code": "-32602"
  }
}

Here is a correct example of a domain with a character not supported, and the error message is the same:

{
  "jsonrpc": "2.0",
  "id": 1,
  "params": {
    "domain": "zonemaster:net"
  },
  "method": "start_domain_test"
}
{
  "jsonrpc": "2.0",
  "id": 1,
  "error": {
    "data": [
      {
        "path": "/domain",
        "message": "The domain name character(s) are not supported"
      }
    ],
    "message": "Invalid method parameter(s).",
    "code": "-32602"
  }
}
@matsduf matsduf added the T-Bug Type: Bug in software or error in test case description label Jun 3, 2022
@matsduf matsduf added this to the v2022.2 milestone Jun 3, 2022
@matsduf matsduf modified the milestones: v2022.2, v2023.1 Dec 20, 2022
@matsduf matsduf modified the milestones: v2023.1, v2023.2 Jun 18, 2023
@tgreenx tgreenx linked a pull request Nov 21, 2023 that will close this issue
@matsduf matsduf modified the milestones: v2023.2, v2024.1 Mar 19, 2024
@matsduf matsduf modified the milestones: v2024.1, v2024.2 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Bug Type: Bug in software or error in test case description
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant