Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When there are no results make job_results return status #1117

Open
mattias-p opened this issue Jul 10, 2023 · 3 comments
Open

When there are no results make job_results return status #1117

mattias-p opened this issue Jul 10, 2023 · 3 comments

Comments

@mattias-p
Copy link
Member

mattias-p commented Jul 10, 2023

Make job_results give the same response as job_status when there are no results to report (e.g. because the job has not finished). A neat thing about this approach is that when you're polling for progress and get a response that the test has terminated, you're getting the results included that same response and you don't have to make an extra call to get the actual results.

Stabilization

Tracking issue

Affected interfaces

Compatibly changed:

  • job_status

Dependencies

Overlapping proposals

None

@matsduf
Copy link
Contributor

matsduf commented Jul 10, 2023

On the other hand, if you have started a batch you might just want to know the progress, and not the result. If I understand the proposal, I think the solution today is cleaner.

@mattias-p
Copy link
Member Author

mattias-p commented Jul 10, 2023

If you just want to know the status of a job it's probably better to call job_status. This issue is about making job_results give better responses. It is not about removing job_status.

@matsduf
Copy link
Contributor

matsduf commented Jul 10, 2023

I see, it was the other way around. Well, that should not hurt anything. It just means that progress is included and result is empty until progress is 100. And error is not reported.

I think the idea is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants