Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client id and version #1122

Open
mattias-p opened this issue Jul 23, 2023 · 3 comments
Open

Remove client id and version #1122

mattias-p opened this issue Jul 23, 2023 · 3 comments

Comments

@mattias-p
Copy link
Member

mattias-p commented Jul 23, 2023

Today job_create and batch_create take client_id and client_version parameters. We make the effort to document and validate them but then we just throw their values away. We should remove these parameters from both job_create and batch_create.

Edit: Up until now I was assuming that we were in fact persisting these arguments in the database, but apparently we don't. I've updated the title and description of this issue to reflect this fact.

Stabilization

Tracking issue

Affected interfaces

Incompatibly changed:

  • job_create
  • batch_create

Dependencies

None

Overlapping proposals

None

@matsduf
Copy link
Contributor

matsduf commented Jul 23, 2023

I see no traces of them in the database schema, but see #1116 where something like it is asked for.

@mattias-p
Copy link
Member Author

Me neither! I just took for granted that we stored them in the test_results table since we make the effort to accept and validate them. I guess it's settled that it's not important then.

@mattias-p mattias-p changed the title Fix or remove client id and version Remove client id and version Jul 24, 2023
@matsduf
Copy link
Contributor

matsduf commented Jul 24, 2023

client_id and client_version are meaningless, but the possibility to store "private data" in the table is requested for our batch tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants