Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test fails in develop branch #1191

Open
matsduf opened this issue Nov 29, 2024 · 1 comment · Fixed by #1192 · May be fixed by #1193
Open

Unit test fails in develop branch #1191

matsduf opened this issue Nov 29, 2024 · 1 comment · Fixed by #1192 · May be fixed by #1193
Labels
P-High Priority: Issue to be solved before other S-PRforIssue Status: There is a PR that is meant to resolve the issue T-Bug Type: Bug in software or error in test case description
Milestone

Comments

@matsduf
Copy link
Contributor

matsduf commented Nov 29, 2024

I have installed develop branch of Zonemaster-LDNS (zonemaster/zonemaster-ldns@f0b7b0a) and Zonemaster-Engine (zonemaster/zonemaster-engine@760f9ea) and try to install a Zonemaster-Backend package from develop branch (dfb8665). When I run the unit tests I get the following error:

t/test01.t ................. # not recording
t/test01.t ................. 1/?     # running the agent on test 1ea22028f16ca7f5
t/test01.t ................. 2/? 
        #   Failed test 'Has correct DS values'
        #   at t/test01.t line 205.
        #     Structures begin differing at:
        #          $got->{keytag} = '29133'
        #     $expected->{keytag} = '51508'
        # Looks like you failed 1 test of 16.

    #   Failed test 'get_data_from_parent_zone'
    #   at t/test01.t line 206.
    # Looks like you failed 1 test of 6.

#   Failed test 'API calls'
#   at t/test01.t line 208.
# running the agent on test 4b926581a879494c
t/test01.t ................. 4/?         # running the agent on test 10222cc72c951c3f
t/test01.t ................. 5/?     # running the agent on test 83eb3b329bdc99c2
    # running the agent on test 65d77bef465d6438
    # running the agent on test 84e18259dfbabcf0
t/test01.t ................. 7/? # Looks like you failed 1 test of 8.
t/test01.t ................. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/8 subtests 
(...)
Test Summary Report
-------------------
t/test01.t               (Wstat: 256 (exited 1) Tests: 8 Failed: 1)
  Failed test:  3
  Non-zero exit status: 1
Files=14, Tests=75, 47 wallclock secs ( 0.12 usr  0.02 sys + 12.52 cusr  1.23 csys = 13.89 CPU)
Result: FAIL
Failed 1/14 test programs. 1/75 subtests failed.
*** Error code 255

PR #1190 also fails.

The combination of the following triggers the issue:

  1. t/test01.t sends external queries even when the network should be off. The responses on those external queries overwrites the recorded data.
  2. There has been changes on live .fr that make it not match the expected values.
@matsduf matsduf added T-Bug Type: Bug in software or error in test case description P-High Priority: Issue to be solved before other labels Nov 29, 2024
@matsduf matsduf linked a pull request Nov 30, 2024 that will close this issue
@matsduf
Copy link
Contributor Author

matsduf commented Nov 30, 2024

Will be fixed by #1192.

@matsduf matsduf added the S-PRforIssue Status: There is a PR that is meant to resolve the issue label Nov 30, 2024
@tgreenx tgreenx added this to the v2024.2 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-High Priority: Issue to be solved before other S-PRforIssue Status: There is a PR that is meant to resolve the issue T-Bug Type: Bug in software or error in test case description
Projects
None yet
2 participants