Make room for other database engines #1139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 22, 2023 10:05
Rely on the "created_at" field to perform the search and ordering in database. This requires the indexes to be updated (which was already the case when runnin batches).
ghost
requested review from
mattias-p,
matsduf,
hannaeko,
tgreenx and
marc-vanderwal
|
@pnax, this is for v2024.1, isn't it? |
yes |
mattias-p
reviewed
Dec 5, 2023
Comment on lines
+514
to
+516
| (SELECT count(*) FROM result_entries JOIN test_results ON result_entries.hash_id = test_results.hash_id AND level = ?) AS nb_critical, | ||
| (SELECT count(*) FROM result_entries JOIN test_results ON result_entries.hash_id = test_results.hash_id AND level = ?) AS nb_error, | ||
| (SELECT count(*) FROM result_entries JOIN test_results ON result_entries.hash_id = test_results.hash_id AND level = ?) AS nb_warning, |
There was a problem hiding this comment.
This looks wrong to me but maybe it just me reading it wrong. Doesn't this joined test_results shadow the test_results in the outer select? If it is, doesn't that mean that the count includes all entries for all tests just as long as they have the right level?
| @@ -81,7 +81,7 @@ sub create_schema { | |||
| ) or die Zonemaster::Backend::Error::Internal->new( reason => "PostgreSQL error, could not create 'test_results' table", data => $dbh->errstr() ); | |||
|
|
|||
| $dbh->do( | |||
| 'CREATE INDEX IF NOT EXISTS test_results__hash_id ON test_results (hash_id)' | |||
There was a problem hiding this comment.
Don't we still need an index for just hash_id? E.g. for the test_progress RPCAPI method.
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR removes the need to have a primary key defined within the database. For instance Clickhouse does not support it. So some specific code is needed. With this PR, such specific code could be removed and the same SQL queries could be used.
Also it appears that when running batches, the indexes are dropped and create again. But one index was not created as intended and included the
created_atfield. However with this PR, an index using thecreated_atfield is necessary to keep good performance. So the initial index is updated (instead of updating the index in the batch method).Context
This was initially part of #1094, and moved to another PR to avoid changing internal while integrating an experimental feature.
Changes
created_atfield and not theidfieldHow to test this PR