Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undelegated tests crash when the domain has a trailing dot #965

Closed
hannaeko opened this issue Sep 27, 2021 · 2 comments · Fixed by #1040
Closed

Undelegated tests crash when the domain has a trailing dot #965

hannaeko opened this issue Sep 27, 2021 · 2 comments · Fixed by #1040
Milestone

Comments

@hannaeko
Copy link
Member

When a test is created on a domain with a trailing dot using user provided nameservers (undelegated test) the test will crash.

Seconds Level     Message
======= ========= =======
Argument $domain must omit the trailing dot, or it must be a single dot at /usr/local/share/perl5/5.32/Zonemaster/CLI.pm line 653.

But when launching the test without the custom ns, the test will work correctly (even with a trail dot on the domain).

When the test is created by the GUI an unhelpful message is shown the user: BACKEND_TEST_AGENT:UNSPECIFIED:UNABLE_TO_FINISH_TEST

@matsduf
Copy link
Contributor

matsduf commented Sep 27, 2021

This relates to the updates of test case Basic00 in PR zonemaster/zonemaster#942.

@tgreenx tgreenx linked a pull request Nov 3, 2022 that will close this issue
@tgreenx
Copy link
Contributor

tgreenx commented Sep 17, 2024

Solved by #1040 (and zonemaster/zonemaster-cli#357 and zonemaster/zonemaster-backend#1132) in v2024.1.

@tgreenx tgreenx closed this as completed Sep 17, 2024
@tgreenx tgreenx added this to the v2024.1 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants