Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lab): prevent tasks linking to themselves #7097

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented May 9, 2024

A second go at fixing this, previously fixed in #5925. Pass the current task key as a prop to NextTaskSelector. Filter the list of tasks to exclude that task key, so that a task can't link back to itself.

This has to be edited in the editors for each individual task type, but I think I got them all.

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@eatyourgreens eatyourgreens force-pushed the fix-next-task-selector branch 2 times, most recently from b819b35 to 97aa532 Compare May 9, 2024 21:11
@coveralls
Copy link

coveralls commented May 9, 2024

Coverage Status

coverage: 56.656% (-0.03%) from 56.684%
when pulling 8448bd9 on eatyourgreens:fix-next-task-selector
into 8ad3b19 on zooniverse:master.

@eatyourgreens eatyourgreens changed the title fix: prevent tasks linking to themselves fix(lab): prevent tasks linking to themselves May 10, 2024
@eatyourgreens eatyourgreens force-pushed the fix-next-task-selector branch from 89b96c0 to f489c32 Compare May 19, 2024 11:30
@eatyourgreens eatyourgreens force-pushed the fix-next-task-selector branch 3 times, most recently from b6c4231 to 4abdbb3 Compare June 5, 2024 04:36
@eatyourgreens eatyourgreens force-pushed the fix-next-task-selector branch from 4abdbb3 to 967a3ef Compare June 8, 2024 01:45
@eatyourgreens eatyourgreens force-pushed the fix-next-task-selector branch from 967a3ef to 24ff284 Compare June 18, 2024 14:55
A second go at fixing this, previously fixed in zooniverse#5925. Pass the current task key as a prop to `NextTaskSelector`. Filter the list of tasks to exclude that task key, so that a task can't link back to itself.

This has to be edited in the editors for each individual task type, but I think I got them all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants