Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lab): clear references to a task key after deleting a task #7099

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented May 10, 2024

A small helper function which iterates through workflow.tasks and deletes references to a given task key. It's called after deleting a task, so that other tasks no longer link to the deleted task.

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@coveralls
Copy link

coveralls commented May 10, 2024

Coverage Status

coverage: 56.673% (-0.01%) from 56.684%
when pulling 75f8111 on eatyourgreens:fix-next-task
into 8ad3b19 on zooniverse:master.

@eatyourgreens
Copy link
Contributor Author

Both the new function and its test were written almost entirely by Copilot. It needs supervision, but seems to be very good at small tasks like this.

@eatyourgreens eatyourgreens changed the title fix: clear references to a task key after deleting a task fix(lab): clear references to a task key after deleting a task May 10, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request: changes to app/pages/lab/workflow.jsx should also be replicated, if possible, on app/pages/lab-fem/workflow.jsx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and rebased to the latest changes on the main branch.

A small helper function which iterates through `workflow.tasks` and deletes references to a given task key. It's called after deleting a task, so that other tasks no longer link to the deleted task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants