Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Builder: add checks for Slider subtask for Drawing Tasks #7186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shaunanoordin
Copy link
Member

@shaunanoordin shaunanoordin commented Sep 19, 2024

PR Overview

Towards #7185

This PR fixes an issue where the Slider subtask is always available for Drawing Tasks('s Drawing Tools).

  • Old behaviour: when choosing to add a subtask to a Drawing Tool, the "Slider" option is always present, alongside the evergreen "Question" and "Text" options.
  • New behaviour: the "Slider" option is ONLY present when project.experimental_tools includes "slider".

NOTE: this new behaviour reflects how the "dropdown" subtask already works.

Testing

Testing steps:

Status

Ready for review.

❗ HOWEVER, do NOT merge until we have completed discussions (see Slack) on how to proceed.

There are two parts to solving the "Drawing Tasks have Slider subtasks" problem:

  • one, this PR, which prevents new Slider subtasks from being created without the experimental flag enabled.
    • (Existing projects that already have Slider subtasks can continue to edit the existing subtasks.)
  • two, some data-cleaning for existing projects that have Slider subtasks without the requisite Slider experimental tool enabled.

… is available before allowing adding Slider subtasks
@shaunanoordin shaunanoordin requested review from lcjohnso and a team September 19, 2024 17:33
@coveralls
Copy link

Coverage Status

coverage: 56.716% (-0.001%) from 56.717%
when pulling 860a982 on slider-dropdown-subtasks
into 8036774 on master.

Copy link
Contributor

@goplayoutside3 goplayoutside3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants