Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve behavior for failed data exports #3366

Open
lcjohnso opened this issue Jun 23, 2020 · 3 comments
Open

Improve behavior for failed data exports #3366

lcjohnso opened this issue Jun 23, 2020 · 3 comments

Comments

@lcjohnso
Copy link
Member

Current behavior: Exports tend to fail silently, leaving a never-changing Export is being generated. message on the Project Builder's Data Export page. Project teams are left uncertain whether they should wait (and for how long) before requesting a new export.

Proposed behavior (rough sketch; feedback and refinement welcome): Pending exports timeout after N hours (24 for workflows and subjects, longer for classifications) and/or after a liveness check on a relevant Sidekiq process comes back false. After timeout or registered failure, clear Export is being generated. message. Bonus: dead/failed jobs are re-tried.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 25, 2020
@lcjohnso
Copy link
Member Author

lcjohnso commented Jan 5, 2021

Reopen stale issue!

@stale stale bot removed the stale label Jan 5, 2021
@camallen
Copy link
Contributor

FWIW I figured out why our exports don't retry. It's due to our use of the https://github.com/parrish/sidekiq-congestion. When the exports are stopped and sidekiq re-queued in redis, sidekiq then tries to re-schedule them (retry) and the congestion middleware stops the job from running as it fails the congestion configs.

We need to modify the way the sidekiq congestion middleware works to have a jobs in flight identifier (that is consistent across the failures / restarts) and check for allow these in-flight jobs to restart without testing the underlying congestion data / configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants