Skip to content

Commit

Permalink
update enable_starttls_auto to true (#346)
Browse files Browse the repository at this point in the history
- in Rails 4.2, the true value and false values are checked. In Rails 5, only false values are checked - unless the values is nil or matches a false value, it is assumed to be true.
- 'true' string no longer evaluates to true. default is true anyway so might as well set to true
  • Loading branch information
yuenmichelle1 authored Jul 18, 2024
1 parent 0b34303 commit 232157f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion config/environments/production.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
config.active_record.raise_in_transactional_callbacks = true

config.action_mailer.smtp_settings = {
enable_starttls_auto: ENV.fetch('MAILER_ENABLE_STARTTLS_AUTO', true),
enable_starttls_auto: true,
address: ENV['MAILER_ADDRESS'],
port: ENV.fetch('MAILER_PORT', 587).to_i,
domain: ENV['MAILER_DOMAIN'] || 'zooniverse.org',
Expand Down
2 changes: 1 addition & 1 deletion config/environments/staging.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
config.active_record.raise_in_transactional_callbacks = true

config.action_mailer.smtp_settings = {
enable_starttls_auto: ENV.fetch('MAILER_ENABLE_STARTTLS_AUTO', true),
enable_starttls_auto: true,
address: ENV['MAILER_ADDRESS'],
port: ENV.fetch('MAILER_PORT', 587).to_i,
domain: ENV['MAILER_DOMAIN'] || 'zooniverse.org',
Expand Down

0 comments on commit 232157f

Please sign in to comment.