Rails 5.2 specs - Remove calling run_callbacks commit spec workarounds (

#378)

* ensure creation when testing after_commit callbacks

* remove run_callbacks workaround on specs, after_commit specs should work without calling callback in Rails 5+

* remove accidental secondary creation

spec/models/announcement_spec.rb

@@ -9,10 +9,10 @@
   end
 
   context 'creating' do
-    let(:announcement){ create :announcement }
+    let(:announcement){ build :announcement }
     it 'should publish' do
       expect(AnnouncementWorker).to receive :perform_async
-      announcement.run_callbacks :commit
+      announcement.save!
     end
   end
 

spec/models/notification_spec.rb

@@ -30,10 +30,10 @@
   end
 
   context 'creating' do
-    let(:notification){ create :notification }
+    let(:notification){ build :notification }
     it 'should publish' do
       expect(NotificationWorker).to receive :perform_async
-      notification.run_callbacks :commit
+      notification.save!
     end
   end