Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save last downloaded URL & display it in post download page #953

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DivergentEuropeans
Copy link
Member

@DivergentEuropeans DivergentEuropeans commented Dec 6, 2024

Simple use of localStorage to store last downloaded URL and then add it to post download page. This doesnt break Legal because it is after the Agree/Disagree step

This adds support to V3, V2, V1, CLI, Client SDKs etc. and every major downloadable thing I see in the Downloads section

image image image

@DivergentEuropeans DivergentEuropeans added the enhancement New feature or request label Dec 6, 2024
@DivergentEuropeans DivergentEuropeans self-assigned this Dec 6, 2024
@balhar-jakub
Copy link
Member

I think we can delete the post_download_legacy instead of updating it.

As for the legal, it does create some issues, as later on the URL without the agreement can be shared and then the person using the URL didn't consent to the agreement while being able to download the link. We may need to update the legal text appropriately, if we want to provide the URL.

I believe, though, that the usefulness of the URL is more important than this specific detail. But I would like to hear @jmertic and @MarkAckert

This doesn't change the fact that we need to decouple the download under separate entity instead of being hosted from zowe.org

@MarkAckert
Copy link
Member

post_download_legacy should be kept for now, it's used for downloading artifacts which have a GPG signature instead of a sigstore bundle available. This is Zowe < 2.18.1 and <3.0.0, and some non-core projects that appear on the downloads page.
If we change post_download to handle both cases, then we can delete post_download_legacy

I don't have additional input on legality other than noting this would offer a change on how we direct users, which Jakub noted. If they follow click here to try a download again, it brings them back to the legal agreement right now.

To the click here point..is there a reason that click here button is insufficient as-is? What problem are we solving adding a JFrog link display to the download text? And as text, not a hyperlink?

@jmertic
Copy link
Contributor

jmertic commented Dec 12, 2024

I think the biggest legal issue is that the binaries must be hosted on a tool owned by the Zowe Binary Project Series LLC. No matter what happens - that needs done.

Aside from that, we should make best effort to drive people through the EULA. I wouldn't over-index if people are clever enough to decipher URLs

@balhar-jakub
Copy link
Member

@jmertic Can you create a fork of this repository in the organization you talk about? That way the only remaining thing needed is to set up the GH page.

Then updating the links here, which is something I can simply do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants