Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

transaction cache needs blocknumber #4

Open
jimscarver opened this issue Sep 8, 2020 · 4 comments
Open

transaction cache needs blocknumber #4

jimscarver opened this issue Sep 8, 2020 · 4 comments

Comments

@jimscarver
Copy link

The block number is needed in the transaction cache to determine if transaction votes were sent during the allowed voting period. @dckc

@dckc
Copy link

dckc commented Sep 8, 2020

timestamp isn't enough? I don't understand this issue.

@dckc
Copy link

dckc commented Sep 8, 2020

I do see "validAfterBlockNumber": 374572

@jimscarver
Copy link
Author

if votes are valid up to block 374575 does than make "validAfterBlockNumber": 374572 valid or invalid?

@dckc
Copy link

dckc commented Sep 8, 2020

ok, well, I think we can get the block number from a deploy id using an observer node

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants