Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZStack build failed for missing org.zstack:log4j2 dependency #1266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ZStack build failed for missing org.zstack:log4j2 dependency #1266

wants to merge 1 commit into from

Conversation

lshmouse
Copy link
Contributor

@lshmouse lshmouse commented Apr 3, 2020

ZStack build failed for missing org.zstack:log4j2 dependency.

$mvn clean install package -DskipTests
...
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:11 min
[INFO] Finished at: 2020-04-03T12:43:32+08:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project build: Could not resolve dependencies for project org.zstack:build:war:3.9.0: Failure to find org.zstack:log4j2:jar:3.9.0 in http://nexus.d.xiaomi.net/nexus/content/groups/public was cached in the local repository, resolution will not be reattempted until the update interval of nexus has elapsed or updates are forced -> [Help 1

Solution: Move the org.zstack:log4j2 dependency under premium profile.

live4thee
live4thee reviewed Apr 3, 2020
View reviewed changes
build/pom.xml
@@ -462,6 +462,11 @@
<artifactId>zbox</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You moved the dependency to the "premium" profile - that is not expected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no org.zstack:log4j2 module under zstack and the maven can not find this dependency during building. So i guess the module is under premium version and move it there. Any suggestion about the placement of org.zstack:log4j2 dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@live4thee Could we just remove this log4j2 dependency?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the code base and it turned out that your patch is correct. I will merge it. Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@live4thee live4thee live4thee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lshmouse @live4thee