Date Picker improvement #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
akbatra567
reviewed
Oct 11, 2024
index.html
Outdated
Comment on lines
101
to
120
| <script> | ||
| const today = new Date(); | ||
| const yesterday = new Date(today.setDate(today.getDate())).toISOString().split('T')[0]; | ||
| document.getElementById('pickupDate').setAttribute('min', yesterday); | ||
| </script> | ||
| <div class="form-group"> | ||
| <label for="dropoffDate">Drop-off Date</label> | ||
| <input type="date" id="dropoffDate"> | ||
| </div> | ||
| <script> | ||
| const minDateInput = document.getElementById('pickupDate'); | ||
| const maxDateInput = document.getElementById('dropoffDate'); | ||
| minDateInput.addEventListener('change', function() { | ||
| const selectedMinDate = new Date(minDateInput.value); | ||
| // Set max date as selected min date | ||
| const maxDate = new Date(selectedMinDate.setDate(selectedMinDate.getDate())).toISOString().split('T')[0]; | ||
| maxDateInput.setAttribute('min', maxDate); | ||
| }); | ||
| </script> | ||
| </div> |
There was a problem hiding this comment.
Do not add new script tags, add this script in the tag at the at line 612.
Also, look at why the css is showing that there are error even after the first load:
Current Version:
Changes in this PR:
akbatra567
added
the
status: requested-changes
|
@akbatra567 kindly review the updated index.html file and let know if any other changes are to be made |
|
could you take a pull there are some merge conflicts in index.html file ? @shalini-bhandari |
akbatra567
approved these changes
Oct 14, 2024
akbatra567
added
status: merge-conflicts
|
i want to work on this can you assign this to me |
@RITIK-CHAUDHRY, this is a PR and not an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Before : Past Date could be selected
After changes : Minimum date for Pickup Date is set to today and for dropoff minimum is set to what the user selected as pickup date
Fixes #139
Type of Change
Checklist:
Screenshot of final output/video
Screen.Recording.2024-10-07.at.10.20.10.mov