Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deps] Update diem deps #66

Merged
merged 5 commits into from
Oct 14, 2023
Merged

[deps] Update diem deps #66

merged 5 commits into from
Oct 14, 2023

Conversation

0o-de-lally
Copy link
Contributor

  • update to diem 1.6.2-rc.2

@0o-de-lally 0o-de-lally marked this pull request as ready for review October 14, 2023 01:18
@0o-de-lally 0o-de-lally requested review from 0xzoz and sirouk October 14, 2023 01:18
0xzoz
0xzoz approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@0xzoz 0xzoz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got trigger happy and approved without realizing txs test fails. Otherwise LGTM. Was going to mention this when it came in but assumed it was for testing purposes.

@0o-de-lally
Copy link
Contributor Author

Got trigger happy and approved without realizing txs test fails. Otherwise LGTM. Was going to mention this when it came in but assumed it was for testing purposes.

it was a false negative. Once it reran manually it passed

@0o-de-lally 0o-de-lally merged commit f53ed49 into 0LNetworkCommunity:main Oct 14, 2023
10 checks passed
0o-de-lally added a commit that referenced this pull request Aug 8, 2024
@0o-de-lally
[deps] Update diem deps (#66)
295a8cb
0o-de-lally added a commit that referenced this pull request Aug 8, 2024
@0o-de-lally
[deps] update diem deps (#66)
e8d562d
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
@0o-de-lally
[deps] Update diem deps (0LNetworkCommunity#66)
313dfd8
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
@0o-de-lally
[deps] Update diem deps (0LNetworkCommunity#66)
e492eee
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
@0o-de-lally
[deps] Update diem deps (0LNetworkCommunity#66)
781a102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xzoz 0xzoz 0xzoz approved these changes

@sirouk sirouk Awaiting requested review from sirouk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0o-de-lally @0xzoz