[Testing Infra] V6 genesis recovery state test suite

[0o-de-lally]

Adding functional tests for ol-genesis-tools for:

• parsing a db backup,
• exporting a JSON intermediary file,
• generating a blob,
• and finally starting a test node from that blob.
• plus one e2e test which does the whole flow.
• test a single validator import from json and check the genesis matches
• * test a sample recovery file, and check the genesis matches

• the test infrastructure is done, but the test is failing.

[0o-de-lally]

R4R @simsekgokhan @nelaturuk @sirouk @corynthian

[simsekgokhan]

R4R @simsekgokhan @nelaturuk @sirouk @corynthian

LGTM

[corynthian]

Minor nitpicks, other than these (maybe I missed something) but I am not seeing where the account state post initialization is compared with the state used for recovery (e.g. checking that balances are the same / state is the same as expected).

[0o-de-lally]

Minor nitpicks, other than these (maybe I missed something) but I am not seeing where the account state post initialization is compared with the state used for recovery (e.g. checking that balances are the same / state is the same as expected).

Good call. Yeah checking the state should be done (I have a todo: somewhere). For now I'll do a single query, since real tests of this need some better introspection tools.

The best testsuite to do that is Forge or the higher level Smoke Tests. Though I'm not entirely sure how to start a Forge instance with an arbitrary Genesis blob. Maybe a volunteer of @simsekgokhan can figure this out?

[0o-de-lally]

@corynthian I've pushed the changes you asked for including an onchain verifcation.

@simsekgokhan Please confirm that running diem-node --test actually uses all the genesis data, or only the stdlib code. I think this may not be the best way to check onchain state. See my changes to e2e_test.rs.

I think Forge, or Smoke test may be the only way to introspect this correctly. But I think some refactoring is needed to have it use a genesis.blob

[0o-de-lally]

@sirouk @0xzoz @hemulin I think this is ready to merge. I depend on it for the next PR #1231

[0o-de-lally]

@0xzoz can you merge?

[0xzoz]

@0xzoz can you merge?

I dont have write access. It would be good to get one more approval as well. My eyes are not as well trained as others🙂